fix: support dns and dnsaddr #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why but we currently can't parse `/dns/foo.com/...` or `/dnsaddr/foo.com/...` so this PR fixes that.
lidel
approved these changes
Jun 24, 2022
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
lgtm, but feels really weird we were missing them for so long 👀
Potential explanation:
/dns/was not supported because go version did not – i filled multiformats/go-multiaddr-dns#47 to fix that/dnsaddrmissing here is strange, I remember resolving it was added around libp2p/js-libp2p#782, but perhaps it was always normalized to/ip*before creating Multiaddr instance, so we never noticed this gap?
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
### [10.2.1](v10.2.0...v10.2.1) (2022-06-24) ### Bug Fixes * support dns and dnsaddr ([#253](#253)) ([53fb15f](53fb15f))
|
🎉 This PR is included in version 10.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the reasoning was behind this but we currently can't parse
/dns/foo.com/...or/dnsaddr/foo.com/...so this PR fixes that.