This repository was archived by the owner on Sep 3, 2021. It is now read-only.
fix: typing mappings #137
Merged
fix: typing mappings #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression introduced by #131 due to incorrect type mappings
carsonfarmer
approved these changes
Dec 12, 2020
vmx
approved these changes
Dec 12, 2020
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Approve by proxy as enough folks who know what they are doing said it works.
Member
|
Thanks a lot @carsonfarmer and @Gozala. I've published a 1.1.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced by #131 due to incorrect type mappings.
P.S.: It was not caught by js-ipfs because import end up having
anytype