Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Conversation

@bluelovers
Copy link
Contributor

avoid typescript esModuleInterop issues

avoid `esModuleInterop` issues
@jacobheun jacobheun requested a review from vmx July 16, 2020 14:51
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeal @rvagg could you have a look at this. You are deeper into JS stuff atm. Do you see a problem with such a self-reference?

@jacobheun
Copy link

This is likely related to multiformats/js-multiformats#18

@rvagg
Copy link
Member

rvagg commented Jul 20, 2020

This is to avoid the default-exports problem, right @bluelovers? Over at ipld/team-mgmt#81 (comment) I was suggesting that as we go forward with ESM we might want to avoid default exports entirely where possible because of the dramas surrounding it. I imagine this is the same sort of problem but it only arises when using TypeScript (or other faux-ESM solutions?). I'm not clear on that part and how you'd trigger a problem with this package because it's not ESM but I think I'm starting to be a fan of exporting explicitly things for the next year or two!

@Gozala
Copy link
Contributor

Gozala commented Dec 15, 2020

So many things have changed here that, I don't think thing is going to work anymore. I think the option moving forward is to address this, if it is an issue, in https://github.com/multiformats/js-multiformats

Hopefully soon enough we'll migrate to the new CIDs from there.

@Gozala Gozala closed this Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants