Ignore error if can't write back multistream protocol id #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
commented
Jun 24, 2022
| @@ -665,7 +665,7 @@ func (rob *readonlyBuffer) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func TestNegotiateFail(t *testing.T) { | |||
| func TestNegotiatThenWriteFail(t *testing.T) { | |||
There was a problem hiding this comment.
@marten-seemann highlighting this change. I'm changing this test so that it passes with the current behavior (negotiate works even if you can't write to it).
There was a problem hiding this comment.
This change goes makes this behavor more like negotiatelazy (wrt write errors). See the previous change here: https://github.com/multiformats/go-multistream/pull/85/files#diff-e59d8a202c91e1303878fa9a18fea9f6a2e3258b609bf4cc1874a17314cb26f8L679
marten-seemann
approved these changes
Jun 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #87. It's the same thing, but we didn't account for the case the the stream is closed so early we don't get a chance to write our multistream select protocol id.
Worth noting that the old NegotiateLazy also ignored this error, so it should be a safe change (since this is the same as the old behavior).