refactor: keep same api as v0.14.0 for SplitFirst/SplitLast#271
Merged
refactor: keep same api as v0.14.0 for SplitFirst/SplitLast#271
Conversation
Not worth breaking this function, and it saves us some pain with updating downstream deps
sukunrt
approved these changes
Feb 21, 2025
| return nil | ||
| } | ||
| return []Component{c} | ||
| return []Component{*c} |
Member
There was a problem hiding this comment.
should we make these slices with a higher capacity?
Contributor
Author
There was a problem hiding this comment.
It's hard to predict how a user will use this. If they want a higher capacity they should just use the slice of Components directly
util.go
Outdated
Comment on lines
85
to
86
| } | ||
| return m[:len(m)-1], m[len(m)-1] | ||
| return m[:len(m)-1], &m[len(m)-1] |
Member
There was a problem hiding this comment.
This looks unsafe.
last points to the last element in the slice. So appends to the first bit(the multiaddr) will modify last, right?
Member
There was a problem hiding this comment.
The same argument also applies to SplitFunc
Contributor
Author
There was a problem hiding this comment.
Added a defensive copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps not worth breaking this function, and it saves us some pain with updating downstream deps. For example, drand would not require a backport of this change to work with multiaddr.
The risk of then calling a method on the returned nil pointer is alleviated by changing the Component methods to be pointer receiver (as before) and checking for nil pointers explicitly.
Would also remove these breaking changes: