don't listen on all interfaces in tests, unless on CI #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Feb 23, 2021
marten-seemann
force-pushed
the
dont-listen-on-all-interfaces
branch
2 times, most recently
from
848ebfa
to
bcf23b7
Compare
marten-seemann
force-pushed
the
dont-listen-on-all-interfaces
branch
from
bcf23b7
to
8c84127
Compare
|
This PR should be ready for merging. I don't have write permissions on this repo, so I can't do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
go testcurrently pops us this warning on OSX:Arguably, we shouldn't listen on public addresses on development machines. We can still run the test on CI, as every CI I know of sets the CI environment variable.