Skip to content

Conversation

@radarhere
Copy link
Collaborator

@radarhere radarhere commented Mar 25, 2022

@radarhere
Copy link
Collaborator Author

I've also added a commit to pass IS_ALPINE to the test image environment.

-e WHEEL_SDIR="$WHEEL_SDIR" \
-e MANYLINUX_URL="$MANYLINUX_URL" \
-e TEST_DEPENDS="$TEST_DEPENDS" \
-e IS_ALPINE="$IS_ALPINE" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place where this is tested?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is tested that it runs without failing.

install_run $PLAT

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the IS_ALPINE is set in the scripts, so it is not needed here.

if [ "$MB_ML_LIBC" == "musllinux" ]; then

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, but it is set based on the value of MB_ML_LIBC, which is not passed through either.

We can use that instead if you prefer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems even if we pass IS_ALPINE through, it will be reset, so it would be better to pass MB_ML_LIBC through.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@mattip
Copy link
Collaborator

mattip commented Apr 2, 2022

Thanks

@radarhere radarhere deleted the alpine branch April 2, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants