-
Notifications
You must be signed in to change notification settings - Fork 93
Updated to Alpine 3.15 test image #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've also added a commit to pass |
travis_linux_steps.sh
Outdated
| -e WHEEL_SDIR="$WHEEL_SDIR" \ | ||
| -e MANYLINUX_URL="$MANYLINUX_URL" \ | ||
| -e TEST_DEPENDS="$TEST_DEPENDS" \ | ||
| -e IS_ALPINE="$IS_ALPINE" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place where this is tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is tested that it runs without failing.
multibuild/tests/test_multibuild.sh
Line 59 in 9f80fef
| install_run $PLAT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the IS_ALPINE is set in the scripts, so it is not needed here.
Lines 34 to 35 in 82f0388
| if [ "$MB_ML_LIBC" == "musllinux" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true, but it is set based on the value of MB_ML_LIBC, which is not passed through either.
We can use that instead if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems even if we pass IS_ALPINE through, it will be reset, so it would be better to pass MB_ML_LIBC through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done.
|
Thanks |
After multi-build/docker-images#29, and seen at https://hub.docker.com/r/multibuild/alpine3.15_x86_64, we can now use Alpine 3.15.