Cleanup talpid tunnel unix module
#7411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
cleanup-talpid-tunnel-unix-mod
branch
from
04fbe78 to
6203aa4
Compare
dlon
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Use `tun::AsyncDevice` instead of hand-rolling an async tunnel device with `tun::Device` + sys calls.
MarkusPettersson98
force-pushed
the
cleanup-talpid-tunnel-unix-mod
branch
from
6203aa4 to
8713e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #7410 which just cleans up code in the
talpid-tunnelby leveraging theasyncfeature oftun.This change is