Move management interface to its own package #7399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
So nice!! 🔥 🙌
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
desktop/packages/management-interface/package.json line 6 at r1 (raw file):
"author": "Mullvad VPN", "license": "GPL-3.0", "description": "",
⛏️ Could we add a quick description of this module? The mullvad-management-interface crate has the following description
Mullvad VPN IPC. Contains types and functions for IPC clients and servers.
Maybe we could write something similar here? 😊
Code quote:
"description": "",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the gRPC code generation for the management interface into its own npm package. This makes the file structure, build process and usage cleaner and easier to follow.
This change is