Improve-ephemeral-peer-error-logs

[Serock3]

---

This change is 

[dlon]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[hulthe]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)

---

talpid-wireguard/src/lib.rs line 978 at r1 (raw file):

async fn log_tunnel_data_usage(config: &Config, tunnel: &Arc<AsyncMutex<Option<Box<dyn Tunnel>>>>) {
    let tunnel = tunnel.lock().await;
    let Ok(tunnel_stats) = tunnel.as_ref().unwrap().get_tunnel_stats() else {

nit: maybe prefer to just return if the tunnel is None instead of unwrapping, even if it currently will always be Some

[hulthe]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dlon and @Serock3)

---

talpid-wireguard/src/lib.rs line 978 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

nit: maybe prefer to just return if the tunnel is None instead of unwrapping, even if it currently will always be Some

i.e.

    let Some(tunnel) = &*tunnel else { return }

[hulthe]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @dlon and @Serock3)

---

talpid-tunnel-config-client/src/lib.rs line 361 at r1 (raw file):

    ) -> std::task::Poll<std::io::Result<()>> {
        std::pin::Pin::new(&mut self.s).poll_shutdown(cx)
    }

nit : There's a lot of fully qualified type paths here, a bit too much noise imo. Maybe consider removing some of them? Also, isn't Unpin in the prelude??

[hulthe]

Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @dlon and @Serock3)

---

talpid-tunnel-config-client/src/lib.rs line 330 at r1 (raw file):

        let bytes = std::task::ready!(std::pin::Pin::new(&mut self.s).poll_read(cx, buf));
        if bytes.is_ok() {
            self.rx_bytes += buf.filled().len();

Nothing's stopping the caller from providing a partially filled ReadBuf here, in which case this addition would be wrong.

[hulthe]

Reviewable status: 1 of 4 files reviewed, 4 unresolved discussions (waiting on @dlon and @Serock3)

---

talpid-tunnel-config-client/src/lib.rs line 344 at r1 (raw file):

        let bytes = std::task::ready!(std::pin::Pin::new(&mut self.s).poll_write(cx, buf));
        if bytes.is_ok() {
            self.tx_bytes += buf.len();

The inner writer is not guaranteed to write all of buf. You need to inspect bytes (which is a Result<usize>) to see how many bytes were written.

[Serock3]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @dlon and @hulthe)

---

talpid-tunnel-config-client/src/lib.rs line 330 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Nothing's stopping the caller from providing a partially filled ReadBuf here, in which case this addition would be wrong.

Done.

---

talpid-tunnel-config-client/src/lib.rs line 344 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

The inner writer is not guaranteed to write all of buf. You need to inspect bytes (which is a Result<usize>) to see how many bytes were written.

Done.

[hulthe]

Reviewed 2 of 2 files at r3, 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[dlon]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved