Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spacing between content and bottom button #7381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olmoh
Copy link
Collaborator

@olmoh olmoh commented Dec 19, 2024

Changes spacing to 24px between content button at bottom of content


This change is Reviewable

Copy link

linear bot commented Dec 19, 2024

@olmoh olmoh force-pushed the change-space-between-list-items-and-buttons-des-72 branch from 597b44d to bd2c478 Compare December 19, 2024 11:25
@olmoh olmoh requested a review from raksooo December 20, 2024 09:41
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)


desktop/packages/mullvad-vpn/src/renderer/components/SplitTunnelingSettings.tsx line 502 at r1 (raw file):

        $flexDirection="column"
        $gap={Spacings.spacing6}
        $margin={{ bottom: measurements.verticalViewMargin }}>

Do we want to use verticalViewMargin like this? IMO it should only be used for the margin of the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants