Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relay selector for smart routing #7050

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Oct 23, 2024

When exit constraints match a DAITA relay, multihop is off, direct only is off and DAITA is turned on, the app should connect via singlehop to the eligible DAITA relays.


This change is Reviewable

@rablador rablador added bug iOS Issues related to iOS labels Oct 23, 2024
@rablador rablador self-assigned this Oct 23, 2024
Copy link

linear bot commented Oct 23, 2024

@rablador rablador force-pushed the fix-relay-selector-for-smart-routing-ios-896 branch from d4f940e to 14b3f94 Compare October 23, 2024 11:07
pinkisemils
pinkisemils previously approved these changes Oct 23, 2024
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I like the simplicity of this changeset.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@rablador rablador force-pushed the fix-relay-selector-for-smart-routing-ios-896 branch from 14b3f94 to 17c3779 Compare October 23, 2024 11:23
pinkisemils
pinkisemils previously approved these changes Oct 23, 2024
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)


ios/MullvadVPNTests/MullvadREST/Relay/RelayPickingTests.swift line 82 at r3 (raw file):

    // MARK: DAITA/Direct only

    // DAITA - ON, Direct only - ON, Multihop - OFF, Exit supports DAITA - FALSE

the comment should be // DAITA - ON, Direct only - OFF, Multihop - OFF, Exit supports DAITA - FALSE

@rablador rablador force-pushed the fix-relay-selector-for-smart-routing-ios-896 branch from 17c3779 to 3cf53e7 Compare October 23, 2024 13:08
Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPNTests/MullvadREST/Relay/RelayPickingTests.swift line 82 at r3 (raw file):

Previously, mojganii wrote…

the comment should be // DAITA - ON, Direct only - OFF, Multihop - OFF, Exit supports DAITA - FALSE

Done.

Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)

@pinkisemils pinkisemils force-pushed the fix-relay-selector-for-smart-routing-ios-896 branch from 3cf53e7 to 55518a3 Compare October 23, 2024 13:50
@pinkisemils pinkisemils merged commit 39960a2 into main Oct 23, 2024
10 of 11 checks passed
@pinkisemils pinkisemils deleted the fix-relay-selector-for-smart-routing-ios-896 branch October 23, 2024 14:02
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants