-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relay selector for smart routing #7050
Fix relay selector for smart routing #7050
Conversation
d4f940e
to
14b3f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
14b3f94
to
17c3779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPNTests/MullvadREST/Relay/RelayPickingTests.swift
line 82 at r3 (raw file):
// MARK: DAITA/Direct only // DAITA - ON, Direct only - ON, Multihop - OFF, Exit supports DAITA - FALSE
the comment should be // DAITA - ON, Direct only - OFF, Multihop - OFF, Exit supports DAITA - FALSE
17c3779
to
3cf53e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPNTests/MullvadREST/Relay/RelayPickingTests.swift
line 82 at r3 (raw file):
Previously, mojganii wrote…
the comment should be
// DAITA - ON, Direct only - OFF, Multihop - OFF, Exit supports DAITA - FALSE
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
3cf53e7
to
55518a3
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
When exit constraints match a DAITA relay, multihop is off, direct only is off and DAITA is turned on, the app should connect via singlehop to the eligible DAITA relays.
This change is