Add info modals to default access methods screens #6905
Conversation
rablador
force-pushed
the
change-encrypted-dns-proxy-info-text-copy-ios-849
branch
2 times, most recently
from
faae446 to
e5f3ecf
Compare
There was a problem hiding this comment.
Reviewed 14 of 15 files at r1, all commit messages.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @rablador)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 90 at r1 (raw file):
"DIRECT_ACCESS_METHOD_HEADER_LINK", tableName: "APIAccess", value: "About Direct method...",
It kinda reads weird like this, it should probably be "About the direct method..."
Or if we go the Apple way, we just put "Learn more..."
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
If you are not connected to our VPN, then the Encrypted DNS proxy will use your own non-VPN IP \ when connecting. The DoH servers are hosted by one of the following providers: Quad 9, CloudFlare, or Google.
"Cloudflare" (no uppercase F)
"Quad 9" should not have a space between Quad and 9
There was a problem hiding this comment.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 90 at r1 (raw file):
Previously, buggmagnet wrote…
It kinda reads weird like this, it should probably be "About the direct method..."
Or if we go the Apple way, we just put "Learn more..."
I agree, but I have followed the copy in Figma.
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
Previously, buggmagnet wrote…
"Cloudflare" (no uppercase F)
"Quad 9" should not have a space between Quad and 9
have followed the copy in Figma, but I guess we can change pure naming errors?
There was a problem hiding this comment.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 90 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
I agree, but I have followed the copy in Figma.
We should follow Figma here.
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
have followed the copy in Figma, but I guess we can change pure naming errors?
Nope, it should be Quad9 and Cloudflare.
There was a problem hiding this comment.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
have followed the copy in Figma, but I guess we can change pure naming errors?
Well Figma is wrong, so we need to update it there too ( :
There was a problem hiding this comment.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
Previously, buggmagnet wrote…
Well Figma is wrong, so we need to update it there too ( :
Matilda has been notified.
There was a problem hiding this comment.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 90 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
We should follow Figma here.
Done.
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift line 227 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Matilda has been notified.
Done. And to clarify, I agree that we should change to the correct names.
rablador
force-pushed
the
change-encrypted-dns-proxy-info-text-copy-ios-849
branch
from
e5f3ecf to
ef6126d
Compare
pinkisemils
force-pushed
the
change-encrypted-dns-proxy-info-text-copy-ios-849
branch
from
ef6126d to
47a0834
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
pinkisemils
deleted the
change-encrypted-dns-proxy-info-text-copy-ios-849
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Changes were made to the info text for the Encrypted DNS proxy, where one of the providers was written incorrectly. Also, to show this info text, new headers have been added to each default access method screen.
This change is