Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript across packages #897

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Upgrade typescript across packages #897

merged 3 commits into from
Sep 5, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 5, 2022

Also noticed that the docs package is currently using 3.8.3:

warn  - Minimum recommended TypeScript version is v4.3.2, older versions can potentially be incompatible with Next.js. Detected: 3.8.3

=>

> yarn list typescript
├─ [email protected]
│  └─ [email protected]
└─ [email protected]

This also results from not having a real dependency on a docs package but just importing from a workspace inside of a github dependency. Our docs don't really use the dependencies we think it's using. I added a dependency to typescript to the docs workspace and that fixed the problem.

> yarn list typescript
├─ [email protected]
│  ├─ [email protected]
│  │  └─ [email protected]
│  └─ [email protected]
└─ [email protected]

It now becomes clear it had hoisted typescript from typescript-to-proptypes to the root of the docs folder.

Anyway, that should be fixed now. No new typescript issues on the docs, only on the toolpad app.

See mui/material-ui#33031

@render
Copy link

render bot commented Sep 5, 2022

@oliviertassinari oliviertassinari requested a deployment to upgrade-ts - toolpad-db PR #897 September 5, 2022 14:38 — with Render Abandoned
@Janpot Janpot merged commit 4104163 into master Sep 5, 2022
@Janpot Janpot deleted the upgrade-ts branch September 5, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants