Add more info to console error detection in integration tests #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-881.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cc8c7fs41lsceb61mlgg. |
oliviertassinari
requested a deployment
to
integration-upd - toolpad-db PR #881
Render
Abandoned
|
this was the run that had failed https://app.circleci.com/pipelines/github/mui/mui-toolpad/2858/workflows/1440fe9e-1988-4294-8558-e389259fae6a/jobs/10285 i guess it was something flaky with the test showing a console error but yeah, the message isn't very helpful :D |
apedroferreira
approved these changes
Sep 1, 2022
test/playwright/test.ts
Outdated
| @@ -18,14 +19,21 @@ const IGNORED_ERRORS = [ | |||
|
|
|||
| export const test = base.extend({ | |||
| page: async ({ page }, use) => { | |||
| const entries: ConsoleEntry[] = []; | |||
| const entriePromises: Promise<ConsoleEntry>[] = []; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make error more visible for debugging purposes