Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only sign in to dockerhub if we intend to push images #867

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Only sign in to dockerhub if we intend to push images #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ jobs:
steps:
- checkout

# login docker hub
- run: |
echo "$DOCKER_PASS" | docker login --username $DOCKER_USER --password-stdin

# build the application image
- run: |
docker build \
Expand Down Expand Up @@ -186,6 +182,10 @@ jobs:
condition:
equal: [master, << pipeline.git.branch >>]
steps:
# login docker hub
- run: |
echo "$DOCKER_PASS" | docker login --username $DOCKER_USER --password-stdin

- run: |
docker push muicom/toolpad:$CIRCLE_SHA1
docker tag muicom/toolpad:$CIRCLE_SHA1 muicom/toolpad:alpha
Expand Down