-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix scroll restoration in the docs #866
[core] Fix scroll restoration in the docs #866
Conversation
docs/package.json
Outdated
@@ -61,7 +61,7 @@ | |||
"lz-string": "^1.4.4", | |||
"markdown-to-jsx": "^7.1.7", | |||
"marked": "^4.0.17", | |||
"next": "12.2.0", | |||
"next": "^12.2.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two different Next.js app (one for the docs, one for toolpad), I'm keeping this one in sync with the docs-infra not toolpad. I think that it's beneficial to have two different Next.js versions to make sure they are decoupled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should decouple @mui/monorepo
as well?
I have found an issue with this approach, it leads to a warning on the core's side. We need to change the import a bit. |
33a51d9
to
7b1b8d9
Compare
41d898d
to
f7f1362
Compare
f7f1362
to
b646e6f
Compare
https://deploy-preview-866--mui-toolpad-docs.netlify.app/toolpad/getting-started/overview/