Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing jsx key warning #851

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix missing jsx key warning #851

merged 1 commit into from
Aug 25, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 25, 2022

Fix missing key warning, and debug why eslint isn't catching this

@render
Copy link

render bot commented Aug 25, 2022

Your Render PR Server URL is https://toolpad-pr-851.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cc3j821gp3ji1kqm9b30.

@oliviertassinari oliviertassinari requested a deployment to jsx-key - toolpad-db PR #851 August 25, 2022 08:34 — with Render Abandoned
apedroferreira
apedroferreira approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this one should be pretty helpful!

@Janpot Janpot merged commit dd5931a into master Aug 25, 2022
@Janpot Janpot deleted the jsx-key branch August 25, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari