Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to ease menu implementation #821

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Add hook to ease menu implementation #821

merged 3 commits into from
Aug 18, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 18, 2022

@render
Copy link

render bot commented Aug 18, 2022

@oliviertassinari oliviertassinari requested a deployment to useMenu-util - toolpad-db PR #821 August 18, 2022 09:02 — with Render Abandoned
@Janpot Janpot marked this pull request as ready for review August 18, 2022 09:30
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these not be 2 separate reusable components instead?
edit: or maybe have the components coming from the hook already, anyway not a big deal deal this seems good

@Janpot
Copy link
Member Author

Janpot commented Aug 18, 2022

could these not be 2 separate reusable components instead?

'aria-controls' and 'aria-labelledby' are cross-referencing each other

@apedroferreira
Copy link
Member

yeah makes sense, first i was thinking those props could come from the outside but since it's always the same pattern a hook works well

@Janpot Janpot enabled auto-merge (squash) August 18, 2022 16:29
@Janpot Janpot merged commit 1d2d9f1 into master Aug 18, 2022
@Janpot Janpot deleted the useMenu-util branch August 18, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants