App renaming integration test #820
Conversation
Janpot
commented
Aug 18, 2022
•
Janpot
commented
- Integration test for Fix App renaming not working #816
- Deduplicate logic around app menu + fix accessibility issues
- Add db backup/restore around integration tests so your dev setup doesn't get polluted
|
Your Render PR Server URL is https://toolpad-pr-820.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbuvhjkgqg4ejjhe7uqg. |
oliviertassinari
requested a deployment
to
integration-test-rename - toolpad-db PR #820
Render
Abandoned
|
|
||
| await page.click(`${locators.toolpadHomeAppRow(appName1)} >> [aria-label="Application menu"]`); | ||
|
|
||
| await page.click('[role="menuitem"]:has-text("Rename"):visible'); |
There was a problem hiding this comment.
Should all the locators used in this test also be present in locators.ts?
There was a problem hiding this comment.
no, just the hacky ones that we want to reuse
| <DriveFileRenameOutlineIcon /> | ||
| </ListItemIcon> | ||
| <ListItemText>Rename</ListItemText> | ||
| </MenuItem> |
There was a problem hiding this comment.
Should we leave the accessibility issue link in there (assuming the issue persists of course)?
There was a problem hiding this comment.
I don't understand the comment. Isn't this how MenuItem is supposed to be used? If it's forcing us to do a workaround in another part of the code then I wouldn't the comment rather belong at that location?
There was a problem hiding this comment.
This was intended to be a reference to the bug report which talks about how MenuItem doesn't work as a button when used with a keyboard; we can remove it since we aren't doing anything specifically to tackle it
