Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the application isn't saved during mounting #779

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 12, 2022

Initial dom is compared with null, which triggers an update. Solution: instead, initialize the ref that stores last saved application with the initial application, this makes it not detect a difference.

Fixes #709

@render
Copy link

render bot commented Aug 12, 2022

@oliviertassinari oliviertassinari requested a deployment to fix-initial-saving - toolpad-db PR #779 August 12, 2022 06:49 — with Render Abandoned
@Janpot Janpot marked this pull request as ready for review August 12, 2022 06:50
@Janpot Janpot changed the title Make sure the DOM isn't saved when mounting Make sure the DOM isn't saved during mounting Aug 12, 2022
@Janpot Janpot changed the title Make sure the DOM isn't saved during mounting Make sure the application isn't saved during mounting Aug 12, 2022
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Janpot Janpot merged commit a1794f5 into master Aug 12, 2022
@Janpot Janpot deleted the fix-initial-saving branch August 12, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening an application without changing marks it as edited
3 participants