Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put datasource in charge of saving the QueryNode #764

Merged
merged 8 commits into from
Aug 10, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 10, 2022

Edit:

Turns out #735 is already fixed by this PR

edit

Also seems to have fixed #686

@render
Copy link

render bot commented Aug 10, 2022

@oliviertassinari oliviertassinari requested a deployment to refactor-query-commit - toolpad-db PR #764 August 10, 2022 09:10 — with Render Abandoned
@Janpot Janpot changed the title Put datasource QueryInput in charge of saving Put datasource in charge of saving the QueryNode Aug 10, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 10, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 10, 2022
@Janpot Janpot marked this pull request as ready for review August 10, 2022 13:44
@Janpot Janpot linked an issue Aug 10, 2022 that may be closed by this pull request
2 tasks
@Janpot Janpot merged commit e9f966c into master Aug 10, 2022
@Janpot Janpot deleted the refactor-query-commit branch August 10, 2022 15:51
@Janpot Janpot linked an issue Aug 22, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch parameters error REST query options are being reset when changing other options
2 participants