Fix custom component slots #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-750.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbmlg5la499fa4qp5os0. |
oliviertassinari
requested a deployment
to
fix-custom-component-slots - toolpad-db PR #750
Render
Abandoned
github-actions
bot
added
the
PR: out-of-date
apedroferreira
force-pushed
the
fix-custom-component-slots
branch
from
4721dff
to
99e075f
Compare
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
force-pushed
the
fix-custom-component-slots
branch
from
0c2b324
to
d5cf2ab
Compare
…t is not dragged inside row or column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix placing components in custom components
slotorslotsprops with any name.Any custom component like this should have an acceptable behavior now, which should be a good baseline for the future even if this feature is still a bit experimental.
Screen.Recording.2022-08-10.at.18.31.52.mov
This fix involved a change to how the editor works: every component has at least one drop area corresponding to its rectangular shape, and another drop area for each empty slot inside it which takes priority.
Closes #713.