Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest datasource: add network inspection #737

Merged
merged 20 commits into from
Aug 9, 2022
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 5, 2022

  • Bring the network panel from the function datasource to the fetch datasource.
  • This requires moving preview and transform to the datasource side.
  • @bharatkashyap to enable this feature I needed to implement a debug call, I added the transform in there as well.
    • To support mutations, we will need POST requests. For non-GET requests, I realized we can't just implicitly call the backend, it must always happen on a clearly indicated user action. I'm afraid we may have to rethink how the transform editor works yet again.

@render
Copy link

render bot commented Aug 5, 2022

@oliviertassinari oliviertassinari requested a deployment to queryeditor-refactor - toolpad-db PR #737 August 5, 2022 06:51 — with Render Abandoned
@Janpot Janpot changed the title Move preview + transform into dataSource Rest datasource: add network inspection Aug 5, 2022
@Janpot Janpot marked this pull request as ready for review August 5, 2022 11:12
@Janpot Janpot merged commit 300bf3c into master Aug 9, 2022
@Janpot Janpot deleted the queryeditor-refactor branch August 9, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants