Drag and drop refactor #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-730.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbl91f2rrk068nfe0mo0. |
oliviertassinari
requested a deployment
to
drag-and-drop-fixes - toolpad-db PR #730
Render
Abandoned
apedroferreira
changed the title
apedroferreira
changed the title
…732) Prevent resizing row child element over adjacent element
* Disallow creating columns in single-child rows * Fix broken zone detection * Improve variable name * Improve readability and shorter variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
RenderPanelcomponent logic in order to try to make it a bit easier to mantain. It's not perfect but it's an improvement, and I'll try to improve more things as I find them.RenderPanelfolderRenderOverlaycomponent - I played around with having a separate component for each of these, and it's possible but it was making things more complicated just for the sake of not taking up as many lines, and it didn't make too much logical sense to split this logic in separate components like that, because they apply to same div/overlay...