-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make function runtime fetch implementation more spec-compliant #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://toolpad-pr-668.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbbtfmirrk07niovcsrg. |
oliviertassinari
requested a deployment
to
module-bundle - toolpad-db PR #668
July 20, 2022 10:24
— with
Render
Abandoned
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 20, 2022
Janpot
changed the title
WIP: spec-compliant fetch for function runtime
Make function runtime fetch implementation more spec-compliant
Jul 20, 2022
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 20, 2022
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 21, 2022
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 21, 2022
Your Render PR Server URL is https://toolpad-pr-668.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbf7cut0mal7b0k8daf0. |
oliviertassinari
requested a deployment
to
module-bundle - toolpad-db PR #668
July 25, 2022 10:54
— with
Render
Abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function datasource runtime runs inside a v8 isolate. We need to provide runtime functionality like
fetch
,setTimeout
,console
,...This PR makes the
fetch
implementation more spec-compliant, and organizes building this runtime from source, rather than providing some javascript in a stringMissing in this PR:
response.blob()
response.arrayBuffer()
AbortController