Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make function runtime fetch implementation more spec-compliant #668

Merged
merged 27 commits into from
Jul 25, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 20, 2022

The function datasource runtime runs inside a v8 isolate. We need to provide runtime functionality like fetch, setTimeout, console,...

This PR makes the fetch implementation more spec-compliant, and organizes building this runtime from source, rather than providing some javascript in a string

  • Build runtime code from source
  • Add basic tests
  • make fetch spec-compliant
    Missing in this PR:
    • response.blob()
    • response.arrayBuffer()
    • AbortController

@render
Copy link

render bot commented Jul 20, 2022

@oliviertassinari oliviertassinari requested a deployment to module-bundle - toolpad-db PR #668 July 20, 2022 10:24 — with Render Abandoned
@Janpot Janpot mentioned this pull request Jul 20, 2022
2 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 20, 2022
@Janpot Janpot changed the title WIP: spec-compliant fetch for function runtime Make function runtime fetch implementation more spec-compliant Jul 20, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 20, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 21, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 21, 2022
@Janpot Janpot marked this pull request as ready for review July 22, 2022 09:28
@render
Copy link

render bot commented Jul 25, 2022

@oliviertassinari oliviertassinari requested a deployment to module-bundle - toolpad-db PR #668 July 25, 2022 10:54 — with Render Abandoned
@Janpot Janpot merged commit fedd79a into master Jul 25, 2022
@Janpot Janpot deleted the module-bundle branch July 25, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants