Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework query editor layout #655

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Rework query editor layout #655

merged 3 commits into from
Jul 13, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 13, 2022 •
edited
Loading

Moving things around in anticipation of giving more control of rendering to the individual datasources.

  • Remove title and use name box + connection selector as title
  • maintain the dialog height to the same height as the screen
  • move client side fetch options to the bottom
  • two pane layout inside with query editor left and previewer on the right

Screenshot 2022-07-13 at 12 49 01

@render
Copy link

render bot commented Jul 13, 2022

Your Render PR Server URL is https://toolpad-pr-655.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cb79cmdi0e886iqr0r3g.

@oliviertassinari oliviertassinari requested a deployment to move-options - toolpad-db PR #655 July 13, 2022 09:54 — with Render Abandoned
@Janpot Janpot changed the title Separate off client-side query options Rework query editor layout Jul 13, 2022
@Janpot Janpot marked this pull request as ready for review July 13, 2022 11:01
@Janpot Janpot merged commit 39c78c1 into master Jul 13, 2022
@Janpot Janpot deleted the move-options branch July 13, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @bharatkashyap @oliviertassinari