Editor - Resizing elements inside page rows #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-645.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cb476ks6fj38j8osbfc0. |
oliviertassinari
requested a deployment
to
editor-element-resizing - toolpad-db PR #645
Render
Abandoned
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
Your Render PR Server URL is https://toolpad-pr-645.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbaqegnh8vld1f3pautg. |
oliviertassinari
requested a deployment
to
editor-element-resizing - toolpad-db PR #645
Render
Abandoned
apedroferreira
force-pushed
the
editor-element-resizing
branch
from
d12da83
to
a9e1c30
Compare
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
changed the title
apedroferreira
changed the title
apedroferreira
commented
Jul 19, 2022
| @@ -1058,6 +1142,16 @@ export default function RenderPanel({ className }: RenderPanelProps) { | |||
| lastContainerChild.parentProp, | |||
| parent.parentIndex, | |||
| ); | |||
|
|
|||
| if (isPageColumn(parent)) { | |||
There was a problem hiding this comment.
i'll probably improve this function later to not have to repeat as much logic- should be done separately though as it relates to the whole editor and not just resizing
github-actions
bot
added
the
PR: out-of-date
|
Your Render PR Server URL is https://toolpad-pr-645.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbf9jgti0e810m439ne0. |
oliviertassinari
requested a deployment
to
editor-element-resizing - toolpad-db PR #645
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #101 and #359
Add ability to resize node elements inside page rows, in the editor:
Screen.Recording.2022-07-19.at.19.46.13.mov
layoutnamespace in page row children to control the value of that propcloses #681