Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pull tag push strategy to fix released docker images #623

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Use pull tag push strategy to fix released docker images #623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d9e43e
revert latest tag to make docker-compose workable again
Janpot Jul 4, 2022
d4bacf1
pull/retag/push instead
Janpot Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions scripts/releaseDocker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,18 @@ async function checkTagExists(image, tag) {
}

async function dockerCreateTag(image, srcTag, destTags) {
const { exitCode, stderr } = await execa(
'docker',
[
'buildx',
'imagetools',
'create',
`${image}:${srcTag}`,
...destTags.flatMap((tag) => ['--tag', `${image}:${tag}`]),
],
{ stdio: 'inherit' },
);
if (exitCode !== 0) {
throw new Error(stderr);
const srImage = `${image}:${srcTag}`;
try {
await execa('docker', ['pull', srImage], { stdio: 'inherit' });
await Promise.all(
destTags.map(async (destTag) => {
const destImage = `${image}:${destTag}`;
await execa('docker', ['tag', srImage, destImage], { stdio: 'inherit' });
await execa('docker', ['push', destImage], { stdio: 'inherit' });
}),
);
} finally {
await execa('docker', ['rmi', srImage], { stdio: 'inherit' });
}
}

Expand Down Expand Up @@ -118,7 +117,7 @@ async function main({ yes, force, commit, releaseTag, 'no-latest': noLatest }) {
}

const parsedVersion = semver.parse(releaseTag);
const isPrerelease = parsedVersion.prerelease.length > 0;
const isPrerelease = parsedVersion ? parsedVersion.prerelease.length > 0 : true;

const tags = [releaseTag];

Expand Down