Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component panel resizable #570

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Make component panel resizable #570

merged 4 commits into from
Jun 20, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 17, 2022

Pull the SplitPane implementation out of #289 and instead use it to make the component panel resizable.

Closes #496

Built with https://github.com/tomkp/react-split-pane, to move to mui/mui-x#512 once ready.

@render
Copy link

render bot commented Jun 17, 2022

@oliviertassinari oliviertassinari temporarily deployed to resizable-componnent-panel - toolpad-db PR #570 June 17, 2022 13:36 — with Render Destroyed
@Janpot Janpot merged commit 74db214 into master Jun 20, 2022
@Janpot Janpot deleted the resizable-componnent-panel branch June 20, 2022 08:55
@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 24, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 24, 2022

  • At some point in the future, we could persist the panel sizes between sessions 😁.
  • I have taken a note that Toolpad could test MUI X window splitter in the future in the benchmark list of Add Splitter component mui-x#512.

@Janpot
Copy link
Member Author

Janpot commented Jun 24, 2022

  • At some point in the future, we could persist the panel sizes between sessions 😁.

We already have the necessary primitives around so I just created #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make properties panel resizable
2 participants