Fix Overlay sizing #543
Merged
Fix Overlay sizing #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-543.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cah29n319n0fr4mh35r0. |
oliviertassinari
temporarily deployed
to
fix-overlay-sizing - toolpad-db PR #543
Render
Destroyed
apedroferreira
approved these changes
Jun 13, 2022
github-actions
bot
added
the
PR: out-of-date
|
Your Render PR Server URL is https://toolpad-pr-543.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cb5ufbfd17c0vgvacbt0. |
oliviertassinari
requested a deployment
to
fix-overlay-sizing - toolpad-db PR #543
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
approved these changes
Jul 12, 2022
| const [editorOverlayRoot, setEditorOverlayRoot] = React.useState<HTMLElement | null>(null); | ||
| const [appRoot, setAppRoot] = React.useState<HTMLElement | null>(null); | ||
|
|
||
| React.useImperativeHandle( |
There was a problem hiding this comment.
nice one, seems like a good idea to have moved these to the ref, as they have to do with the app root more than the render panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make the overlay a child of the app root, so that it can size relative to it. Took the opportunity to remove a few hacks from the
RenderPanelrelated to its communication with the canvasScreen.Recording.2022-06-09.at.18.45.57.mov