[DashboardLayout] Allow custom navigation page items #4809
+1,032
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
added
enhancement
Netlify deploy preview |
apedroferreira
changed the title
|
I'm awaiting this!!! |
Janpot
reviewed
Apr 2, 2025
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "props": { | |||
There was a problem hiding this comment.
🤔 I would have expect this to just have a item prop. Does it need all these other props? This is just to render the default item right? I'm not sure we should expose more API on it.
There was a problem hiding this comment.
If you look at the expanded demo here I was just trying to make this type of changes as easy as possible as well as reusing the existing component. Some of these are things that some users already asked to be able to override.
Would it help if these props were additional options maybe? And the first parameter was the item?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4413.
Closes #4607 both for the hidden and disabled cases.
Helps with #4748 as it allows for overriding the
Linkcomponent used by each item.Also helps with #4733 but additional state management would be needed from the user, so maybe there is a better solution for that in the future.
Also makes it possible to easily mark items as
expanded,selectedordisabled, or use external links with a customhref.Check the new documentation here: