Bump MUI Core #4601
Bump MUI Core #4601
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
renovate
bot
force-pushed
the
renovate/mui-core
branch
from
762d396 to
4cdc68c
Compare
github-actions
bot
added
PR: out-of-date
renovate
bot
force-pushed
the
renovate/mui-core
branch
from
4cdc68c to
a8edde9
Compare
github-actions
bot
removed
the
PR: out-of-date
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @@ -111,7 +111,7 @@ function PagesExplorerTreeItem(props: StyledTreeItemProps) { | |||
| })} | |||
| aria-label="Open page explorer menu" | |||
| size="small" | |||
| {...buttonProps} | |||
| {...(buttonProps as IconButtonProps)} | |||
There was a problem hiding this comment.
Avoid casting, instead fix the type of renderButton in NodeMenu
| @@ -28,7 +35,7 @@ function AppOptions({ dom }: AppOptionsProps) { | |||
|
|
|||
| return ( | |||
| <React.Fragment> | |||
| <IconButton {...buttonProps} aria-label="Application menu"> | |||
| <IconButton {...(buttonProps as IconButtonProps)} aria-label="Application menu"> | |||
There was a problem hiding this comment.
We should probably fix the types of useMenu instead so that they work for both Button and IconButton.
There was a problem hiding this comment.
If I understand correctly, the issue has arisen because of the mismatch in the type of the loading prop between IconButton and Button and everything should work as expected when this issue is resolved without us needing to do anything
There was a problem hiding this comment.
Looks like it. Is there a core issue? We can hold off on upgrading until the issue is resolved
There was a problem hiding this comment.
Can't seem to find an issue for this. @siriwatknp is the difference in the types of IconButton and Button wrt loading intentional? (See my comment above in the thread for the links)
github-actions
bot
added
the
PR: out-of-date
This PR contains the following updates:
6.3.1->6.4.06.3.1->6.4.01.0.24->1.0.251.0.32->1.0.336.0.0-beta.22->6.0.0-beta.236.3.1->6.4.06.3.1->6.4.06.3.1->6.4.06.3.1->6.4.0Release Notes
mui/material-ui (@mui/docs)
v6.4.0Compare Source
Jan 13, 2025
A big thanks to the 16 contributors who made this release possible. Here are some highlights ✨:
loadingprop to theButtonandIconButtoncomponents (#44637) @siriwatknp@mui/[email protected]slotsandslotProps(#44971) @siriwatknploadingprop (#44637) @siriwatknp*TypographyPropsand completeslots,slotProps(#44729) @siriwatknparia-controlswhen closed (#44919) @siddhantantil39mergeSlotPropsfor extending components (#44809) @siriwatknpmergeSlotPropsto mergestyle(#44959) @siriwatknpDocs
c51af8e) @oliviertassinariCore
@mui/internal-test-utils(#45023) @LukasTyAll contributors of this release in alphabetical order: @aarongarciah, @DiegoAndai, @good-jinu, @headironc, @iaziz11, @IceOfSummer, @Janpot, @LukasTy, @mnajdova, @oliviertassinari, @sai6855, @samuelsycamore, @siddhantantil39, @siriwatknp, @yashdev16, @ZeeshanTamboli
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.