Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of next.js custom server #452

Merged
merged 10 commits into from
Jun 23, 2022
Merged

Get rid of next.js custom server #452

merged 10 commits into from
Jun 23, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 20, 2022

It was only there to support basic auth.

edit

Leaving this in draft for a while. _middlewares is a beta feature and they just announced there will be a couple of changes to it. This PR should be compatible with the new changes.

@render
Copy link

render bot commented May 20, 2022

@oliviertassinari oliviertassinari temporarily deployed to remove-custom-server - toolpad-db PR #452 May 20, 2022 15:41 — with Render Destroyed
@Janpot Janpot marked this pull request as draft May 22, 2022 11:38
@render
Copy link

render bot commented May 24, 2022

@oliviertassinari oliviertassinari temporarily deployed to remove-custom-server - toolpad-db PR #452 May 24, 2022 13:01 — with Render Destroyed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 24, 2022
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
(didn't realize it was a draft, I can take a look at the final version too)

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 24, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 2, 2022
@render
Copy link

render bot commented Jun 23, 2022

@oliviertassinari oliviertassinari temporarily deployed to remove-custom-server - toolpad-db PR #452 June 23, 2022 15:00 — with Render Destroyed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2022
@Janpot Janpot marked this pull request as ready for review June 23, 2022 15:24
@Janpot Janpot merged commit ce9c6cd into master Jun 23, 2022
@Janpot Janpot deleted the remove-custom-server branch June 23, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants