Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Update path-to-regexp to 6.3.0 #4126

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[code-infra] Update path-to-regexp to 6.3.0 #4126

merged 1 commit into from
Sep 20, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 20, 2024 •
edited
Loading

Update path-to-regexp to 6.3.0 which contains a fix for GHSA-9wv6-86v2-598j, but doesn't suffer from vitest-dev/vitest#6540

Few fixes to the setup I'm passing along

  • Add react plugin to vite
  • Clean up the workaround for mocking of external modules during vitest browser beta (this was causing flakyness)
  • Remove the alias for icon esm. This has been fixed in @mui/[email protected]

Closes #4125

@Janpot Janpot added dependencies Update of dependencies security Pull requests that address a security vulnerability labels Sep 20, 2024
@Janpot Janpot mentioned this pull request Sep 20, 2024
Closed
@Janpot Janpot added the priority: important This change can make a difference label Sep 20, 2024
@Janpot Janpot requested a review from a team September 20, 2024 14:27
apedroferreira
apedroferreira approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
If we might not be able to merge #4074 for a while I guess I can move the test improvements there to a different PR.

@Janpot Janpot marked this pull request as ready for review September 20, 2024 14:36
@Janpot Janpot enabled auto-merge (squash) September 20, 2024 14:36
@Janpot Janpot merged commit 5715bf2 into mui:master Sep 20, 2024
14 of 15 checks passed
@Janpot Janpot deleted the update-path-to-regexp branch September 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies priority: important This change can make a difference security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@toolpad/core 6 depends on vulnerable versions of path-to-regexp
2 participants
@Janpot @apedroferreira