Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo from feedback #4105

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[docs] Fix typo from feedback #4105

merged 1 commit into from
Sep 17, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 16, 2024

Received feedback:

that accepts the id of the row that is to be deleted

This is section about editing, why "deleted"?

Also taking the opportunity to reduce vale errors (remove "will")

@Janpot Janpot added the docs Improvements or additions to the documentation label Sep 16, 2024
@@ -140,7 +140,7 @@ Uncheck the column option "sortable" if you want to disable sorting for a certai

## Row editing

The data provider can be extended to automatically support row editing. To enable this, you'll have to add a `updateRecord` method to the data provider interface that accepts the `id` of the row that is to be deleted, and an object containing all the updated fields from the row editing operation.
The data provider can be extended to automatically support row editing. To enable this, you'll have to add a `updateRecord` method to the data provider interface that accepts the `id` of the row that is to be edited, and an object containing all the updated fields from the row editing operation.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the update to address the feedback. The rest are vale fixes.

@Janpot Janpot marked this pull request as ready for review September 17, 2024 07:10
@Janpot Janpot requested a review from a team September 17, 2024 07:10
@Janpot Janpot merged commit c2e6577 into mui:master Sep 17, 2024
13 checks passed
@Janpot Janpot deleted the fix-typo branch September 17, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants