Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Replace issue cleanup workflow with centralized one #4077

Conversation

michelengelen
Copy link
Member

related issue: mui/mui-public#193

@michelengelen michelengelen added enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes labels Sep 11, 2024
@michelengelen michelengelen self-assigned this Sep 11, 2024
@michelengelen michelengelen changed the title [infra] Adds reusable workflow for new issue triage [infra] Adds reusable workflow for new issue cleanup Sep 11, 2024
@Janpot
Copy link
Member

Janpot commented Sep 11, 2024

What does this workflow do?

@michelengelen
Copy link
Member Author

It simply unifies the cleanup approach we have on all mui repos

@Janpot
Copy link
Member

Janpot commented Sep 11, 2024

It simply unifies the cleanup approach we have on all mui repos

Cleanup of what? From the issue description I can't get any idea on what this PR is going to change to our repo and from the linked issue neither. Would it be possible to be a bit more descriptive, or point to a description?

@michelengelen
Copy link
Member Author

It simply unifies the cleanup approach we have on all mui repos

Cleanup of what? From the issue description I can't get any idea on what this PR is going to change to our repo and from the linked issue neither. Would it be possible to be a bit more descriptive, or point to a description?

Sry if you did not know what this change is about.

It will technically change nothing only use the reusable workflow from the mui-public repo instead.

The original workflow was there for triaging and formatting the issue body when a new issue got opened. In an effort to centralize and normalize that we moved a few workflows to the mui-public repo and made them reusable, so we have 2 benefits:

  1. whenever we need to change something in those workflows we only have to do it once
  2. we normalize/unify our approach and wording across the public repos

This has been discussed a few times already and also mentioned on the monthly meeting, but I do agree that I could have done a better job at providing a description. Sry about that!
I'll also add the above section to the linked issue.

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, got it now. I initially overlooked that this PR is replacing a workflow, not just adding one. Sry for being a nuisance 🙂.

@Janpot Janpot changed the title [infra] Adds reusable workflow for new issue cleanup [infra] Replace issue cleanup workflow with centralized one Sep 12, 2024
@Janpot Janpot changed the title [infra] Replace issue cleanup workflow with centralized one [code-infra] Replace issue cleanup workflow with centralized one Sep 12, 2024
@michelengelen michelengelen merged commit 9c30b71 into mui:master Sep 12, 2024
15 checks passed
@michelengelen michelengelen deleted the automation/adds-new-issue-triage-workflow branch September 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants