Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Link docs from component demos on Toolpad Core landing page #4013

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Aug 28, 2024

@prakhargupta1 prakhargupta1 added the website Related to the marketing pages label Aug 28, 2024
@prakhargupta1 prakhargupta1 linked an issue Aug 28, 2024 that may be closed by this pull request
@prakhargupta1 prakhargupta1 requested a review from a team August 29, 2024 04:49
@bharatkashyap
Copy link
Member

bharatkashyap commented Aug 29, 2024

I think we could go with this kind of an overlay on the code for the links; much more unmissable and attractive:
Screenshot 2024-08-29 at 1 47 59 PM

@prakhargupta1
Copy link
Member Author

I don't think it will bring much difference.

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could go with this kind of an overlay on the code for the links: much more unmissable and attractive:

Personally I find a link more intuitive than a button as a way to get to a page in our documentation. This follows the X landing page, it feels better to me than to core landing page.

@prakhargupta1 prakhargupta1 merged commit e0c065c into mui:master Sep 5, 2024
14 checks passed
@prakhargupta1 prakhargupta1 deleted the link-docs branch September 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to the marketing pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add docs links to landing page feature section
3 participants