[core] Optimize studio production build #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last few weeks we started getting a lot of flaky integration tests. The CI takes much longer to complete since the move to the inline editor. It's timing out quite often trying to build production apps, which is the cause of the flakyness. I noticed we were bundling the monaco workers in production apps. This is unnecessary as the editor is not being used there. On my local this removed about 3/4 of the production build time.
The main reason for this PR was to fix the flaky CI, but the effect on the bundle sizes of the production Toolpad application is also profound:
master:
This PR:
Lighthouse:
Before:
After:
I address a few more low-hanging fruits in a follow-up PR