Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Enable test coverage for @toolpad/core #3697

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 21, 2024

Enabled coverage for tests of:

  • @toolpad/utils
  • @toolpad/core

Intentionally omitting @toolpad/studio as it's mostly covered by integration tests. No straightforward way to enable coverage for them.

Also enabled uploading to codecov.io. Results for this PR at https://app.codecov.io/github/mui/mui-toolpad/tree/pull%2F3697/

@Janpot Janpot added the test label Jun 21, 2024
@prakhargupta1
Copy link
Member

I was about to create an issue for this.😄

@Janpot Janpot changed the title [test] Enable test coverage [test] Enable test coverage for @toolpad/core Jun 21, 2024
@Janpot Janpot marked this pull request as ready for review June 21, 2024 14:02
@Janpot Janpot requested a review from a team June 21, 2024 14:02
Copy link

codecov bot commented Jun 21, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Janpot Janpot merged commit 4476e5f into mui:master Jun 21, 2024
14 checks passed
@Janpot Janpot deleted the coveragg branch June 21, 2024 16:15
@oliviertassinari
Copy link
Member

Nice.

This also make vitest a closer candidate replacement for mocha + karma. It could be interesting to push that path forward actually. Maybe with https://vitest.dev/guide/browser.html we could drop BrowserStack and gain vitest multithreading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants