Add DashboardLayout component to @toolpad/core #3554
Conversation
| @@ -0,0 +1,69 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Was this hand-written? I think we should port the docs:typescript:formatted script from core
There was a problem hiding this comment.
I hadn't noticed that, I guess I can include it in this PR if it's simple.
There was a problem hiding this comment.
I've added it here, seems to work fine 9465e74
| @@ -0,0 +1,3 @@ | |||
| # Dashboard Layout API | |||
There was a problem hiding this comment.
For the API, let's port the docs generator from X?
There was a problem hiding this comment.
We can do that in this separate PR, right? #3536
There was a problem hiding this comment.
Ah, the X one, I was checking the Base one, will take a look.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
This should be ready as a first version of the |
docs/data/toolpad/studio/pages.js
Outdated
There was a problem hiding this comment.
I don't believe this file is expected to be here. I think it was generated by the demo formatter script. I added a rule in the ignore list as I saw this happening when porting the script from X repo
docs/data/toolpad/core/pages.js
Outdated
There was a problem hiding this comment.
I don't believe this file is expected here, see my other comment below
| export interface NavigationPageItem { | ||
| kind?: 'page'; | ||
| title: string; | ||
| path?: string; |
There was a problem hiding this comment.
With the nomenclature path I'd expect it to be the full path. Maybe we need to come up with another name e.g. like "slug"? That way we can later still add path if we want to add an override in the future.
| path?: string; | |
| slug: string; |
scripts/coreTypeScriptProjects.js
Outdated
There was a problem hiding this comment.
🤔 The file is already in the project, with different casing
Isolated DashboardLayout component and its docs from #3343 and implemented review feedback.
Docs/demo: https://deploy-preview-3554--mui-toolpad-docs.netlify.app/toolpad/core/components/dashboard-layout/
(once we have a navigation adapter we can make the demo sidebar links work with local state to provide better examples)
(API docs generation to be added next in separate PR)
Summary
Please check the types in packages/toolpad-core/src/AppProvider/AppProvider.tsx for the chosen API.
Possible to import types such as
BrandingandNavigationfrom@toolpad/core.Also added
@toolpad/core/themeswhere thebaseThemewe use can be imported from, and that we use as a default theme. Eventually we can provide more themes?Addressed PR comments