Toolpad Core build process #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Janpot
approved these changes
May 14, 2024
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolating build changes from #3343 and implementing review feedback.
(components are still bare bones though as they're more complete in the original PR)
Uses the same build process as Material UI or Base UI (with babel + scripts), which seemed to fix many issues I was having with
tsup.For now,
AppProvidercan be imported as a named import from@toolpad/core/AppProviderandDashboardLayoutthe same way from@toolpad/core/DashboardLayout. They can also be imported directly from@toolpad/core.Addressed PR comments
Olivier:
Jan: