Fix performance regression #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, we have some controlled inputs in the right-side sidebar that are reading the app state to define their value and so they don't perform as well as they could, it's definitely something we should improve. |
apedroferreira
approved these changes
Apr 26, 2024
| appDom.setNodeNamespacedProp(draft, node, namespace as any, name, newValue), | ||
| ); | ||
| setPropValue(newValue); | ||
| React.startTransition(() => { |
There was a problem hiding this comment.
Nice use of this transition API, we could probably use it more in this type of updates.
There was a problem hiding this comment.
Ideally we use it just once in the update method and eliminate all synchronous coupling between app state and its update method in the whole app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3456
After we removed the app build process, the canvas content and the editor started running in the same React tree. The whole editor rendering now affects the responsiveness of the input components.
This PR keeps the input state local and updates the editor state in a transition to make the rendering of these state updates through the editor interruptible.
The input now renders with higher priority than the rest of the app.
Screen.Recording.2024-04-26.at.15.14.47.mov
We may consider calling
startTransitioninside of theupdatemethod. but I believe there will still be places in the UI where an input depends on it synchronously updating the state. We should eliminate this assumption.Also removing some dead code