-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update monorepo #3424
[core] Update monorepo #3424
Conversation
2a8652d
to
e606ad9
Compare
It fails because It works for Base UI mui/base-ui#333 and MUI X mui/mui-x#12861 because we don't use I still struggle to connect the dots to why npm dependency > git dependency for docs infra.
|
The problems you encounter are caused by moving @mui/docs to the published variant before fully removing the monorepo dependency. Now we ended up with two code dependencies that have some shared assumptions about which version is used, but which are imported through two different release cycles. My initial preference was to keep aliasing it from the monorepo dependency until we could fully replace, but the team is eager to move forward with publishing. Similar problems will appear when introducing a different release process for internal and external packages. Unfortunately so far I haven't been able to convince the team about this yet. Will keep trying to find the right argument. In general it's simple: a hybrid of monorepo+aliasing and published packages will cause more problems than either of those on their own. I am going to be clear about the following, if we're moving forward with published npm packages we're going to have a worse system until:
I also agree that we should have tried a git dependency first (still the format of npm packages, but unpublished), at least as a stopgap solution. |
Something is off with the latest version mui/mui-x#12861 (comment) |
e606ad9
to
681c483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoking my review, I didn't look at the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monorepo is up to date now, so I just kept the change to the config.
Added a few more comments around @mui/docs as well
It looks great, thanks |
Propagate mui/material-ui#41901