Use url.pathToFileURL to correctly resolve functions paths on windows #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
changed the title
| import * as fs from 'fs/promises'; | ||
| import { TOOLPAD_DATA_PROVIDER_MARKER, ToolpadDataProvider } from '@toolpad/studio-runtime/server'; | ||
| import * as z from 'zod'; | ||
| import { fromZodError } from 'zod-validation-error'; | ||
| import * as crypto from 'crypto'; | ||
|
|
||
| async function loadExports(filePath: string): Promise<Map<string, unknown>> { | ||
| const fullPath = path.resolve(filePath); | ||
| const content = await fs.readFile(fullPath, 'utf-8'); | ||
| const importFileUrl = url.pathToFileURL(path.resolve(filePath)); |
There was a problem hiding this comment.
Suggested change
| const importFileUrl = url.pathToFileURL(path.resolve(filePath)); | |
| // Correct cross-platform resolution of the import URL | |
| // See: https://nodejs.org/api/url.html#urlpathtofileurlpath | |
| const importFileUrl = url.pathToFileURL(path.resolve(filePath)); |
There was a problem hiding this comment.
In case vscode doesn't suffice? 😄
There was a problem hiding this comment.
😄 I thought it deserves special placement because of the bug. Perhaps we can link to the issue
bharatkashyap
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405
Use
url.pathToFileURLto correctly resolve paths on windows