Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make inline canvas the default #3370

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 8, 2024

This has been under a flag for long enough

There's some more context around inline canvas on #3344 (comment)

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Apr 8, 2024
@Janpot Janpot marked this pull request as ready for review April 8, 2024 16:16
@Janpot Janpot requested a review from a team April 9, 2024 10:22
@bharatkashyap
Copy link
Member

This has been under a flag for long enough

There's some more context around inline canvas on #3344 (comment)

There seems to be some changes that are visual, should we add images to the PR description for those?

@Janpot
Copy link
Member Author

Janpot commented Apr 9, 2024

There seems to be some changes that are visual

Which ones? argos remains stable for this PR

@bharatkashyap
Copy link
Member

There seems to be some changes that are visual

Which ones? argos remains stable for this PR

Changes to the preview header, but on second thought it seems there are no changes, only removals. Okay for me 👍🏻

@Janpot Janpot merged commit 79e83ff into mui:master Apr 9, 2024
12 checks passed
@Janpot Janpot deleted the default-inline-canvas branch April 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants