-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Add a chip to indicate pro features #3358
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this will scale as the amount pro features grows, but that will be a good problem to have. Until then I'm ok with this solution 👍
{!isPaidPlan ? ( | ||
<Tooltip | ||
title={ | ||
<Typography variant="inherit"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a string should be fine, no?
<Typography variant="inherit"> |
<Chip | ||
variant="outlined" | ||
color="primary" | ||
component={'a'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish prettier would fix these
component={'a'} | |
component="a" |
verticalAlign: 'inherit', | ||
mx: '0.2rem', | ||
'& :hover': { | ||
cursor: 'pointer', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cursor: 'pointer', |
use the clickable
prop of the Chip
type?: AlertColor; | ||
feature?: string; | ||
warning?: string; | ||
variant?: 'alert' | 'chip'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just export two components, an alert and a chip
Screen.Recording.2024-04-09.at.5.03.59.PM.mov
<UpgradeAlert />
to change the nature of the alerts toinfo
instead oferror
, which was jarringAlso some minor fixes on the typography of the
<PageOptionsPanel />
':Also some updates to documentation copy to better reflect the paid nature of the gated features