Add rename, duplicate and delete for Page Hierarchy #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
…me-duplicate-delete-hierarchy
github-actions
bot
removed
the
PR: out-of-date
…me-duplicate-delete-hierarchy
Janpot
reviewed
Mar 28, 2024
| }); | ||
|
|
||
| interface StyledTreeItemProps extends TreeItemProps, EditableTreeItemProps { | ||
| labelTextSx?: SxProps; |
There was a problem hiding this comment.
To simplify this a bit, I think you can just supply values for these directly to the NodeMenu component. I see we're exporting CustomTreeItemProps, I don't think this is necessary, we can keep the component local to this module for now.
|
Looks great. Had just one suggestion about simplifying the component a bit. I don't think we intend for this |
Janpot
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen-Record_28-03-2024_14-50.mp4