Fix flaky auth test with console error "Failed to fetch" #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
commented
Mar 11, 2024
| @@ -69,7 +69,7 @@ | |||
| "format-util": "1.0.5", | |||
| "globby": "14.0.1", | |||
| "jsdom": "24.0.0", | |||
| "lerna": "8.1.2", | |||
| "lerna": "7.4.2", | |||
There was a problem hiding this comment.
Using lerna 7 until this gets fixed: lerna/lerna#3964
apedroferreira
force-pushed
the
flaky-test-fix
branch
from
2ee7775
to
8f6370c
Compare
apedroferreira
force-pushed
the
flaky-test-fix
branch
from
2fb4285
to
8e2da66
Compare
Janpot
approved these changes
Mar 13, 2024
github-actions
bot
added
the
PR: out-of-date
I tried as Playwright also doesn't recommend using this method, but the other options didn't work. Edit: Ok looks like waiting for a page element also works, that way we don't use anything that Playwright discourages. |
apedroferreira
changed the title
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by a CSRF token request for auth that fails with "Failed to fetch", only happens in headless mode, probably because the requests there happen fast and previous pending auth requests end up making this one fail.
Waiting for network requests to complete seems to fix the issue.
In a real application this will probably never happen and even if it does it's just a console error.