Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] fix errors not showing up in the rows area #3264

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 1, 2024

This used to be an overlay, but we've hijacked the NoRowsOverlay for this, so we need to make the grid visible

adding a vrt in https://app.argos-ci.com/mui/mui-toolpad/builds/2684/79662068

@Janpot Janpot changed the title [DataGrid] fix errors no showing up in the rows area [DataGrid] fix errors not showing up in the rows area Mar 1, 2024
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Mar 1, 2024
@Janpot Janpot marked this pull request as ready for review March 1, 2024 14:50
@Janpot Janpot requested a review from a team March 1, 2024 14:50
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Janpot Janpot merged commit 1da03b0 into mui:master Mar 1, 2024
11 of 12 checks passed
@Janpot Janpot deleted the fix-error-grid branch March 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants